Conversation
ec8c96a to
70f045d
Compare
70f045d to
efe66f4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10489 +/- ##
===========================================
- Coverage 83.39% 57.71% -25.69%
===========================================
Files 250 223 -27
Lines 75112 17519 -57593
Branches 0 3604 +3604
===========================================
- Hits 62642 10111 -52531
+ Misses 12470 6866 -5604
- Partials 0 542 +542
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
waralexrom
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
refreshKeychanges faster than the query executes (e.g.SELECT NOW()with a slow query),must-revalidategets stuck in an endlessContinue waitloop. Each time the query finishes, the refreshKey has already changed — so it re-runs the query, which never catches up.Fix:
Track which request produced the cached result. If the same request flow already has a result in cache but the refreshKey changed during execution — return the cached data immediately and refresh in the background, instead of blocking and re-executing.