Skip to content

Conversation

@KSDaemon
Copy link
Contributor

@KSDaemon KSDaemon commented Jan 12, 2026

  • add CUBEJS_PRE_AGG_BACKOFF_MAX_TIME env
  • implement PreAggBackoff api in orchestrator pre-aggs
  • impl backoff in refreshScheduler
  • add tests

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@github-actions github-actions bot added the javascript Pull requests that update Javascript code label Jan 12, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.11%. Comparing base (1ea8fe4) to head (de00772).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...y-orchestrator/src/orchestrator/PreAggregations.ts 0.00% 10 Missing ⚠️
...es/cubejs-server-core/src/core/RefreshScheduler.ts 77.77% 3 Missing and 1 partial ⚠️
packages/cubejs-backend-shared/src/env.ts 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1ea8fe4) and HEAD (de00772). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1ea8fe4) HEAD (de00772)
cubesql 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10302       +/-   ##
===========================================
- Coverage   83.28%   55.11%   -28.17%     
===========================================
  Files         248      221       -27     
  Lines       74448    17233    -57215     
  Branches        0     3526     +3526     
===========================================
- Hits        62004     9498    -52506     
+ Misses      12444     7239     -5205     
- Partials        0      496      +496     
Flag Coverage Δ
cube-backend 55.11% <48.27%> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon marked this pull request as ready for review January 13, 2026 11:32
@KSDaemon KSDaemon requested review from a team as code owners January 13, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants