Check if user is present in any of multiple possible group names#271
Open
RoxasShadow wants to merge 6 commits intocschiewek:defaultfrom
Open
Check if user is present in any of multiple possible group names#271RoxasShadow wants to merge 6 commits intocschiewek:defaultfrom
RoxasShadow wants to merge 6 commits intocschiewek:defaultfrom
Conversation
Target cschiewek#149. Should not be a breaking change since both the code and the documentation clearly state that `required_groups` members either are strings, or must have only two elements when any member is an array. The feature here is that we can list a number of groups after the attribute and at least any of them has to be matched to be able to pass the verification.
|
@RoxasShadow do you mean #149 ? |
Author
Yes, that was a typo, thanks! |
it is required for running the tests on newer Rails versions
Author
> rspec spec/unit/connection_spec.rb
..............
Finished in 0.04252 seconds (files took 1.86 seconds to load)
14 examples, 0 failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello nice folk 😄
This PR is an attempt at implementing the feature request in #149, which happens to be also something that my team at @simplybusiness needs as well.
In order to not introducing any breaking changes, I have made possible to add additional elements to any array member of
required_groupsso that we can introduce exclusive operations in without touching any of the inclusive logic operation that are done among all the members ofrequired_groups.I hope this make sense to you. I haven't seen any tests covering the
#in_required_groups?part of#authorized?- I will try to add something here as soon as I am able to run the whole tests suite in my local machine.Thank you.