Add compile-time tests for mdspan-style View template arguments with helper abstraction#27
Draft
Copilot wants to merge 4 commits intoview-with-mdspan-argumentsfrom
Draft
Conversation
…elop.cpp Co-authored-by: crtrott <[email protected]>
…akeLists Co-authored-by: crtrott <[email protected]>
Copilot
AI
changed the title
[WIP] Add tests for mdspan style template arguments in Kokkos::View
Add compile-time tests for mdspan-style View template arguments
Jan 31, 2026
Co-authored-by: crtrott <[email protected]>
Copilot
AI
changed the title
Add compile-time tests for mdspan-style View template arguments
Add compile-time tests for mdspan-style View template arguments with helper abstraction
Jan 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests validating that
Kokkos::Viewconstructed with mdspan-style template arguments (scalar, extents, layout, accessor) produces identicalmdspan_typeas traditional Kokkos style (datatype, layout, space, memorytraits).Changes
New test file:
core/unit_test/view/TestViewMDSpanStyleTemplateArgs.cppKokkos::Experimental::Accessor<ElementType, Space, MemoryTraits>to construct accessorsHelper abstraction (added in separate commit):
test_mdspan_view_equivalence<ElementType, Rank, Layout, Space, MemTraits>: constructs both View styles and compares theirmdspan_typerank_to_asterisks<Rank>: maps rank integer to pointer syntax (T*,T**, etc.)layout_to_mdspan<Layout>: mapsLayoutLeft/Righttolayout_left/right_padded<dynamic_extent>Example
Traditional verbose assertion (10 lines):
Refactored with helper (3 lines):
File reduced from 197→174 lines (12% reduction) while maintaining identical test coverage.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.