improve build-docker-image

[Emilgardis]

No description provided.

[Emilgardis]

/ci try --target x86_64-unknown-linux-gnu

[Emilgardis]

damn, it doesn't spin up the action with the version in this pr :/

[github-actions]

Try run for comment

• try / conclusion - ❌

Failed Jobs

• x86_64-unknown-linux-gnu - ❌

[Emilgardis]

manual check started: https://github.com/cross-rs/cross/actions/runs/13641396443

[Emilgardis]

Closing this in favor of #1636

[reneleonhardt]

@Emilgardis can you restore your branch so I can cherry-pick your improvements on top of 1636?
I don't know why GitHub doesn't allow to download a patch file when the rich diff is still being displayed... 🤷

[Emilgardis]

restored

[reneleonhardt]

Thanks! Is everything needed?
I have to squash everything, but Commit 2 is doubt this works, very WIP 😅

[Emilgardis]

Thanks! Is everything needed? I have to squash everything, but Commit 2 is doubt this works, very WIP 😅

No everything is not needed!

[reneleonhardt]

So how can I know what's needed and what's not?
It would be easier if this branch would only contain improvements to the target branch.

Why don't you target the other pull request yourself like I did for you?
Then you can prepare everything which would be of value for your contributor.

[Emilgardis]

I made this PR to experiment mostly, it was only a draft. The intent was to enable multi-platform building using docker buildx bake but I didn't get that far.

[reneleonhardt]

Ok. And what does it mean? Should your improvements be integrated here or do you want to refine them later?

[Emilgardis]

I don't know what you mean, improvements are good, and they should always be refined. But there's nothing in this specific pr that absolutely has to be included.

[reneleonhardt]

I just tried to help because the contributor said it would be too hard to apply your improvements.
Now your branch could be applied with one click, it's not my decision to actually do it.