Draft
Conversation
Emilgardis
commented
Mar 8, 2023
Member
Author
Emilgardis
left a comment
Emilgardis
left a comment
There was a problem hiding this comment.
This does work, but I'm not happy with the code-reuse.
I want to make Install::run not be a rewrite of cross::run
| &engine, | ||
| cross::CargoMetadata { | ||
| workspace_root: cwd.clone(), | ||
| target_directory: cross::file::absolute_path(self.root)?, |
Member
Author
There was a problem hiding this comment.
this is misleading
cargo install creates a temporary directory where it builds, we don't use this path as the normal target-dir, rather as the target directory for the cargo install output
Comment on lines
1037
to
1051
| ]) | ||
| .args(["-e", "CARGO_TARGET_DIR=/target"]) | ||
| .args(["-e", &cross_runner]); | ||
|
|
||
| if !options.skip_target_dir { | ||
| self.args(["-e", "CARGO_TARGET_DIR=/target"]); | ||
| } | ||
| if options.cargo_variant.uses_zig() { | ||
| // otherwise, zig has a permission error trying to create the cache | ||
| self.args(["-e", "XDG_CACHE_HOME=/target/.zig-cache"]); |
Member
Author
There was a problem hiding this comment.
is this comment about zig a problem?
Comment on lines
+79
to
+82
| if let Some((version, channel, _)) = toolchain.rustc_version()? { | ||
| is_nightly = channel == rustc_version::Channel::Nightly; | ||
| rustc_version = Some(version); | ||
| } |
Member
Author
There was a problem hiding this comment.
this doesn't emit warning on mismatch like normal cross does
Emilgardis
commented
Mar 9, 2023
Comment on lines
+23
to
+28
| /// Path to crate | ||
| #[clap(long)] | ||
| pub path: Option<String>, | ||
| /// Path to Cross.toml | ||
| #[clap(long)] | ||
| pub config: Option<std::path::PathBuf>, |
Member
Author
There was a problem hiding this comment.
this is not implemented
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1215
enables
cross-util install <thing> <args...> --root output