Fix #707 structured content persistence and harden streaming error handling#718
Open
afurm wants to merge 2 commits into
Open
Fix #707 structured content persistence and harden streaming error handling#718afurm wants to merge 2 commits into
afurm wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #718 +/- ##
==========================================
+ Coverage 87.05% 87.10% +0.04%
==========================================
Files 119 119
Lines 5594 5615 +21
Branches 1407 1416 +9
==========================================
+ Hits 4870 4891 +21
Misses 724 724 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes #707 by preserving structured string-keyed content across the ActiveRecord persistence boundary instead of reloading it as
RubyLLM::Content::Raw.This PR also hardens streaming error handling so the test matrix stays green:
to_s/to_jsonrepresentation forContent::Rawenvobjects in generic and Bedrock streaming error pathsFARADAY_VERSIONFixes #707.
Type of change
Scope check
Required for new features
PRs for new features or enhancements without a prior approved issue will be closed.
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)Validation run locally:
bundle exec rubocoprails-7.1,rails-7.2,rails-8.0,rails-8.1FARADAY_VERSION=1.10.3.gitleaks.tomlAI-generated code
API changes