Skip to content

Conversation

@henderkes
Copy link
Collaborator

What does this PR do?

closes #1017

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

@henderkes henderkes marked this pull request as ready for review January 17, 2026 09:53
@henderkes
Copy link
Collaborator Author

4 more weeks until the macos 8.5 bug is finally fixed

Copy link
Owner

@crazywhalecc crazywhalecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code part looks good, but I haven't tested locally yet.

@henderkes
Copy link
Collaborator Author

Feel free to merge when you tested. I didn't care to test the extension past a php -i | grep excimer.

@henderkes henderkes merged commit ae0217b into main Jan 19, 2026
11 of 13 checks passed
@henderkes henderkes deleted the feat/excimer branch January 19, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add excimer profiler support

3 participants