Maintain dynamic count of URLs per crawl ID#141
Closed
klockla wants to merge 1 commit intocrawler-commons:masterfrom
Closed
Maintain dynamic count of URLs per crawl ID#141klockla wants to merge 1 commit intocrawler-commons:masterfrom
klockla wants to merge 1 commit intocrawler-commons:masterfrom
Conversation
Signed-off-by: Laurent Klock <Laurent.Klock@arhs-cube.com>
Collaborator
|
sorry don't have time to look at it in details but how is it different from |
Collaborator
Author
yes, I see your point now :) What I really needed was the total nb of URLs per crawl, I got a bit confused by GetStats and the concepts of active URLs (I mixed it at some point with "in process") and I didn't realize that the total number of URLs can be retrieved with Getstats: active + completed URLs....so I guess we can conclude that there is no need for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new API call: GetCrawlStats which will return the number of completed and total URLs per crawl.