Added Daikin 312 protocol support#2246
Merged
crankyoldgit merged 6 commits intocrankyoldgit:masterfrom Feb 7, 2026
Merged
Conversation
This was referenced Feb 4, 2026
Owner
|
Hi, I'm currently travelling so I won't get to this properly for a week or so. I'll take a quick look now. |
crankyoldgit
approved these changes
Feb 7, 2026
Owner
crankyoldgit
left a comment
crankyoldgit
left a comment
There was a problem hiding this comment.
Looks good to me!
Thanks for doing this and for using unit tests too! ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a PR for the work done by @AntonWert to support the Daikin 312 protocol in the issue #1829
Tested on ARC466A58