Skip to content

Conversation

@jmg-duarte
Copy link
Contributor

Description

Removes the AlloyEventRetriever wrapper, at this point, we've migrated all contracts, etc, it's no longer needed.

Changes

  • Removes the AlloyEventRetriver
  • Updates call sites accordingly

How to test

Existing tests

The AlloyEventRetriever wrapper was introduced as a temporary measure
to avoid conflicts during the migration from ethcontract to alloy.
Now that the migration is complete, this wrapper is no longer needed.

This commit removes the wrapper and directly implements EventRetrieving
for types that implement AlloyEventRetrieving, simplifying the type
signatures across the codebase.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@jmg-duarte jmg-duarte requested a review from a team as a code owner January 7, 2026 12:06
@gemini-code-assist
Copy link

Summary of Changes

Hello @jmg-duarte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the event handling infrastructure by eliminating the AlloyEventRetriever wrapper. This wrapper was initially introduced to facilitate a smooth transition during the migration of contracts to the Alloy framework. With the migration now complete, the wrapper has become redundant, and its removal simplifies the codebase and improves clarity by allowing direct interaction with the underlying event retrieval mechanisms.

Highlights

  • Code Simplification: The AlloyEventRetriever wrapper type has been removed as it is no longer necessary after the full migration of contracts to the Alloy framework. This simplifies the event retrieval logic.
  • Direct Type Usage: Call sites that previously wrapped types with AlloyEventRetriever now directly use the underlying contract types, streamlining the code and removing an unnecessary layer of indirection.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jmg-duarte jmg-duarte marked this pull request as draft January 7, 2026 12:08
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully removes the AlloyEventRetriever wrapper type, which simplifies the codebase after a migration. The changes are straightforward and correctly applied across multiple crates. My review focuses on some minor formatting inconsistencies that were introduced. I've suggested changes to improve readability and maintain a consistent style across the project. Overall, this is a good cleanup PR.

@jmg-duarte jmg-duarte merged commit 51a0e4f into jmgd/alloy/events Jan 8, 2026
17 checks passed
@jmg-duarte jmg-duarte deleted the jmgd/alloy/alloy_events branch January 8, 2026 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants