-
Notifications
You must be signed in to change notification settings - Fork 151
Remove AlloyEventRetriever wrapper type #4032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The AlloyEventRetriever wrapper was introduced as a temporary measure to avoid conflicts during the migration from ethcontract to alloy. Now that the migration is complete, this wrapper is no longer needed. This commit removes the wrapper and directly implements EventRetrieving for types that implement AlloyEventRetrieving, simplifying the type signatures across the codebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Summary of ChangesHello @jmg-duarte, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the event handling infrastructure by eliminating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully removes the AlloyEventRetriever wrapper type, which simplifies the codebase after a migration. The changes are straightforward and correctly applied across multiple crates. My review focuses on some minor formatting inconsistencies that were introduced. I've suggested changes to improve readability and maintain a consistent style across the project. Overall, this is a good cleanup PR.
Description
Removes the AlloyEventRetriever wrapper, at this point, we've migrated all contracts, etc, it's no longer needed.
Changes
How to test
Existing tests