fix: stop review PR flow before merge#479
Open
haosenwang1018 wants to merge 1 commit intocovibes:mainfrom
Open
fix: stop review PR flow before merge#479haosenwang1018 wants to merge 1 commit intocovibes:mainfrom
haosenwang1018 wants to merge 1 commit intocovibes:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
--prworkflow so it creates a review PR and stops, while keeping--shipas the mode that continues into merge/auto-complete.Related Issues
Fixes #452
Changes Made
shipintent asautoMergein cluster start optionsautoMergethrough orchestrator PR options into git-pusher generationgit-pusher-templateprompt generation so review-only PR mode stops after PR creation instead of always forcing step 6 mergemerge_commit_shain structured output when merge/auto-complete is actually expectedTesting
node -c src/agents/git-pusher-template.jsgenerateGitPusherAgent()checks for review-only and ship mode behaviornpx mocha tests/structuredOutput-mapping.test.jsChecklist
npm test)