fix: hide child process windows on Windows#472
Open
haosenwang1018 wants to merge 2 commits intocovibes:mainfrom
Open
fix: hide child process windows on Windows#472haosenwang1018 wants to merge 2 commits intocovibes:mainfrom
haosenwang1018 wants to merge 2 commits intocovibes:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowsHide: trueto the detached watcherfork()pathwindowsHide: trueto the watcher child spawn pathwindowsHide: trueto the agent task executor and Claude task runner spawn pathsWhy
Issue #459 reports that zeroshot spawns visible console windows for child Node.js processes on Windows.
Node's
spawn()/fork()create those windows by default on Windows unlesswindowsHide: trueis set. Since zeroshot launches background watcher/task processes, those extra consoles are just UI noise and make the tool feel broken in desktop use.Testing
./node_modules/.bin/mocha tests/providers/detection.test.jswindowsHide: trueFixes #459