Skip to content

RSCBC-264: OrphanReporter - Replace log sink and increase log level#468

Merged
Matt-Woz merged 1 commit intomainfrom
RSCBC-264
Mar 9, 2026
Merged

RSCBC-264: OrphanReporter - Replace log sink and increase log level#468
Matt-Woz merged 1 commit intomainfrom
RSCBC-264

Conversation

@Matt-Woz
Copy link
Contributor

@Matt-Woz Matt-Woz commented Mar 9, 2026

Changes

  • Move orphan reporting log level up from debug to warn
  • Remove log sink and replace it in tests with a fmt subscriber writer

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates orphan reporting to emit via tracing at info level instead of using a configurable log sink, and adjusts tests to capture output through a tracing-subscriber fmt writer.

Changes:

  • Switch orphan reporter summary logging from debug! to info! and remove the custom log_sink plumbing.
  • Remove log_sink from OrphanReporterConfig (and related types/helpers).
  • Update orphan reporter tests to capture logs using a custom MakeWriter + tracing-subscriber.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
sdk/couchbase-core/src/orphan_reporter.rs Removes sink-based logging and emits orphan summaries via tracing::info!.
sdk/couchbase-core/src/options/orphan_reporter.rs Drops log_sink from the public config API.
sdk/couchbase-core/tests/orphan_reporter_test.rs Replaces sink-based assertions with tracing-subscriber output capture.
sdk/couchbase-core/Cargo.toml Adds tracing-subscriber as a dev-dependency for the updated tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

🐰 Bencher Report

BranchRSCBC-264-22866494815-137-1
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)
Upper Boundary
microseconds (µs)
(Limit %)
query📈 view plot
🚷 view threshold
427.03 µs
(+1.85%)Baseline: 419.29 µs
482.18 µs
(88.56%)
upsert_and_get📈 view plot
🚷 view threshold
406.66 µs
(+1.99%)Baseline: 398.74 µs
458.56 µs
(88.68%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link

github-actions bot commented Mar 9, 2026

🐰 Bencher Report

BranchRSCBC-264-22867023419-140-1
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)
Upper Boundary
microseconds (µs)
(Limit %)
query📈 view plot
🚷 view threshold
446.46 µs
(+6.48%)Baseline: 419.29 µs
482.18 µs
(92.59%)
upsert_and_get📈 view plot
🚷 view threshold
413.83 µs
(+3.78%)Baseline: 398.74 µs
458.56 µs
(90.25%)
🐰 View full continuous benchmarking report in Bencher

@Matt-Woz Matt-Woz merged commit 738ec31 into main Mar 9, 2026
16 checks passed
@Matt-Woz Matt-Woz deleted the RSCBC-264 branch March 9, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants