Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates orphan reporting to emit via tracing at info level instead of using a configurable log sink, and adjusts tests to capture output through a tracing-subscriber fmt writer.
Changes:
- Switch orphan reporter summary logging from
debug!toinfo!and remove the customlog_sinkplumbing. - Remove
log_sinkfromOrphanReporterConfig(and related types/helpers). - Update orphan reporter tests to capture logs using a custom
MakeWriter+tracing-subscriber.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/couchbase-core/src/orphan_reporter.rs | Removes sink-based logging and emits orphan summaries via tracing::info!. |
| sdk/couchbase-core/src/options/orphan_reporter.rs | Drops log_sink from the public config API. |
| sdk/couchbase-core/tests/orphan_reporter_test.rs | Replaces sink-based assertions with tracing-subscriber output capture. |
| sdk/couchbase-core/Cargo.toml | Adds tracing-subscriber as a dev-dependency for the updated tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
| Branch | RSCBC-264-22866494815-137-1 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold | 427.03 µs(+1.85%)Baseline: 419.29 µs | 482.18 µs (88.56%) |
| upsert_and_get | 📈 view plot 🚷 view threshold | 406.66 µs(+1.99%)Baseline: 398.74 µs | 458.56 µs (88.68%) |
|
| Branch | RSCBC-264-22867023419-140-1 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result microseconds (µs) (Result Δ%) | Upper Boundary microseconds (µs) (Limit %) |
|---|---|---|---|
| query | 📈 view plot 🚷 view threshold | 446.46 µs(+6.48%)Baseline: 419.29 µs | 482.18 µs (92.59%) |
| upsert_and_get | 📈 view plot 🚷 view threshold | 413.83 µs(+3.78%)Baseline: 398.74 µs | 458.56 µs (90.25%) |
chvck
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
debugtowarn