The patch for the zlib is not needed after 1.2.13 version#109
The patch for the zlib is not needed after 1.2.13 version#109mrserb wants to merge 1 commit intocorretto:developfrom
Conversation
| "${project.rootDir}/", buildRoot | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
I would like to leave the code to apply patches in, we do use this functionality in other versions and make need it again here.
There was a problem hiding this comment.
Do we actually use it? I think we do not do it and instead always push to the repo, the one exception is JFX.
There was a problem hiding this comment.
Not sure I like the solution when the source code has one version of the file, the build via make will use that file, but the build via gradle will use some other customized files.
There was a problem hiding this comment.
We use it in 11 https://github.com/corretto/corretto-11/tree/develop/installers/linux/alpine/tar/patches
I think there was a patch that didn't play nice on other platforms and there wasn't a nice way to have it be MUSL_AARCH64 only, but I could be wrong.
There was a problem hiding this comment.
So if that patch will fail we even will not know that...
I'll postpone this change and take a look at that patch.
Custom patches for Zlib are removed. All that changes are present in the bundle zlib library.