Skip to content

Add NONEwithRSA support#519

Merged
WillChilds-Klein merged 11 commits intocorretto:mainfrom
WillChilds-Klein:rsa-pkcs15-ph
Mar 2, 2026
Merged

Add NONEwithRSA support#519
WillChilds-Klein merged 11 commits intocorretto:mainfrom
WillChilds-Klein:rsa-pkcs15-ph

Conversation

@WillChilds-Klein
Copy link
Contributor

@WillChilds-Klein WillChilds-Klein commented Feb 26, 2026

Notes

Builds on PR #515.

NONEwithRSA is a JDK-standard Signature algorithm. This PR adds support for that while refactoring NONEwithRSASSA-PSS JNI logic to deduplicate logic.

We don't provide benchmarks for NONEwithRSA or NONEwithRSASSA-PSS to reduce noise -- relevant benchmarks already provide performance coverage over small messages (i.e. digests in these cases).

Testing

  • interop tests with JCE + BC, no need for KATs
  • new unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 81.42857% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.55%. Comparing base (5809f2f) to head (6dee28f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
csrc/sign.cpp 73.68% 6 Missing and 4 partials ⚠️
...m/amazon/corretto/crypto/provider/NoneWithRsa.java 90.32% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #519      +/-   ##
============================================
- Coverage     77.57%   77.55%   -0.03%     
- Complexity     1144     1150       +6     
============================================
  Files           119      119              
  Lines          7260     7292      +32     
  Branches        924      927       +3     
============================================
+ Hits           5632     5655      +23     
- Misses         1134     1142       +8     
- Partials        494      495       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WillChilds-Klein WillChilds-Klein changed the title Rsa pkcs15 ph Add NONEwithRSA support Feb 26, 2026
@WillChilds-Klein WillChilds-Klein marked this pull request as ready for review March 2, 2026 16:15
@WillChilds-Klein WillChilds-Klein requested a review from a team as a code owner March 2, 2026 16:15
@WillChilds-Klein WillChilds-Klein enabled auto-merge (squash) March 2, 2026 17:36
Copy link
Contributor

@geedo0 geedo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the javadoc for the RFC references.

@WillChilds-Klein WillChilds-Klein requested a review from geedo0 March 2, 2026 20:57
@WillChilds-Klein WillChilds-Klein merged commit afcbb82 into corretto:main Mar 2, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants