Add NONEwithRSA support#519
Merged
WillChilds-Klein merged 11 commits intocorretto:mainfrom Mar 2, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
============================================
- Coverage 77.57% 77.55% -0.03%
- Complexity 1144 1150 +6
============================================
Files 119 119
Lines 7260 7292 +32
Branches 924 927 +3
============================================
+ Hits 5632 5655 +23
- Misses 1134 1142 +8
- Partials 494 495 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7cd45d3 to
0522ea9
Compare
geedo0
requested changes
Mar 2, 2026
Contributor
geedo0
left a comment
There was a problem hiding this comment.
Just update the javadoc for the RFC references.
2f15060 to
6dee28f
Compare
geedo0
approved these changes
Mar 2, 2026
justsmth
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes
Builds on PR #515.
NONEwithRSAis a JDK-standard Signature algorithm. This PR adds support for that while refactoringNONEwithRSASSA-PSSJNI logic to deduplicate logic.We don't provide benchmarks for
NONEwithRSAorNONEwithRSASSA-PSSto reduce noise -- relevant benchmarks already provide performance coverage over small messages (i.e. digests in these cases).Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.