fix: Cancel Subcourses correctly when deactivating a student#1280
Draft
fix: Cancel Subcourses correctly when deactivating a student#1280
Conversation
Jonasdoubleyou
previously approved these changes
Sep 5, 2025
…rst to prevent notifications during cancellations
Jonasdoubleyou
approved these changes
Sep 8, 2025
| // There are multiple instructors, so just remove the student from the subcourse | ||
| if (subcourse.subcourse_instructors_student.length > 1) { | ||
| await deleteSubcourseInstructor(userForStudent(student), subcourse, student); | ||
| } else if (!(await subcourseOver(subcourse))) { |
Member
There was a problem hiding this comment.
If the course is over, we also do not want to remove the instructor if there are multiple instructors?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves https://github.com/corona-school/project-user/issues/1526
What was done?
cancelSubcoursewhen a student is deactivated, so we also cancel appointments (and its reminders for the participants)