Disable map view, fix admin add rides flow#647
Open
mjaydenkim wants to merge 3 commits intomasterfrom
Open
Conversation
Custom locations! No longer takes like five clicks to add a location on the admin side!
Member
|
[diff-counting] Significant lines: 244. |
YottaYocta
requested changes
Jan 4, 2026
Collaborator
There was a problem hiding this comment.
Hi Matthew! Thanks for your PR. Requesting a ride from the admin side worked for me. I think we should discuss the possibilities of reworking the UI in the future, especially how custom string rides work address selection in our system, but I feel that that task is out of scope for now.
I ran into some issues on the rider client when trying to click 'details'; do you have any ideas on what to show on the rider side if a custom string address is requested?
Collaborator
Contributor
Author
|
@YottaYocta i think these issues have been fixed, take a look ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Test Plan
Tested app functionality with and without flags and scheduling rides from admin side