Skip to content

Disable map view, fix admin add rides flow#647

Open
mjaydenkim wants to merge 3 commits intomasterfrom
mk2672/fix-add-rides-modals
Open

Disable map view, fix admin add rides flow#647
mjaydenkim wants to merge 3 commits intomasterfrom
mk2672/fix-add-rides-modals

Conversation

@mjaydenkim
Copy link
Contributor

Summary

  • Implement flag to enable/disable map view (due to custom locations, admins don't want the map view yet)
  • Fix admin change location modal (flow was kinda clumsy before)
  • Add custom locations to admin add location modal
    • Note: there isn't any address validation like there is in the student page. This is easy to implement but I was wondering if we should give admins more leverage to input fully custom addresses; worth discussing in reviews though.

Test Plan

Tested app functionality with and without flags and scheduling rides from admin side

Custom locations! No longer takes like five clicks to add a location on the admin side!
@mjaydenkim mjaydenkim requested a review from a team as a code owner January 1, 2026 20:08
@dti-github-bot
Copy link
Member

dti-github-bot commented Jan 1, 2026

[diff-counting] Significant lines: 244.

Copy link
Collaborator

@YottaYocta YottaYocta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Matthew! Thanks for your PR. Requesting a ride from the admin side worked for me. I think we should discuss the possibilities of reworking the UI in the future, especially how custom string rides work address selection in our system, but I feel that that task is out of scope for now.

I ran into some issues on the rider client when trying to click 'details'; do you have any ideas on what to show on the rider side if a custom string address is requested?

Image

@YottaYocta
Copy link
Collaborator

image Forgot to include this, but in the admin scheduler panel, the locations of custom rides aren't being displayed

@mjaydenkim mjaydenkim mentioned this pull request Jan 6, 2026
2 tasks
@mjaydenkim mjaydenkim requested a review from YottaYocta January 7, 2026 22:42
@mjaydenkim
Copy link
Contributor Author

@YottaYocta i think these issues have been fixed, take a look !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants