pnpm branch: Replace Create React App with Vite#635
Open
benkoppe wants to merge 9 commits intobek76/pnpm-sharedfrom
Open
pnpm branch: Replace Create React App with Vite#635benkoppe wants to merge 9 commits intobek76/pnpm-sharedfrom
pnpm branch: Replace Create React App with Vite#635benkoppe wants to merge 9 commits intobek76/pnpm-sharedfrom
Conversation
Continue using REACT_APP prefix for saved github actions secrets
Member
|
[diff-counting] Significant lines: 6799. This diff might be too big! Developer leads are invited to review the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces CRA (Create React App) with Vite. It's a redo of PR #605: now post-
pnpmand post-shared folder. This makes the implementation much cleaner, and means the Docker CI actually works so we can observe just how much faster our builds are now.Breaking Changes
Caution
Make sure you replace the
REACT_APP_prefix withVITE_in your frontend.envfile!! Otherwisepnpm devwon't work.I like to keep both versions of the env vars so I can still checkout version of the repo with CRA. So just copy all your env vars and replace that prefix below.
pnpm dev.