NO-JIRA: renovate: restrict schedule to Sunday mornings#232
NO-JIRA: renovate: restrict schedule to Sunday mornings#232joelcapitao merged 1 commit intocoreos:mainfrom
Conversation
We set a range that enables Renovate to run 2 iterations (00h00 and 04h00). That way, it will be able to propose commits and automerge them in the second iteration. However, if a new update comes in the meantime, Renovate will update the commit and won't be able to automerge it afterward. This cornercase cannot be mitigated easily. If we extend the range to have one more iteration, then there is more chances to have an update.
joelcapitao
changed the title
|
@joelcapitao: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, joelcapitao The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Renovate configuration to improve the description and restrict the schedule for bootc base container image updates. The reviewer noted that the proposed cron expression '* 0-6 * * 0' would trigger every minute, potentially causing excessive runs, and suggested using '0 0,4 * * 0' to align with the intended schedule of running at 00:00 and 04:00 UTC on Sundays.
3 participants
We set a range that enables Renovate to run 2 iterations (00h00 and 04h00). That way, it will be able to propose commits and automerge them in the second iteration. However, if a new update comes in the meantime, Renovate will update the commit and won't be able to automerge it afterward. This cornercase cannot be mitigated easily. If we extend the range to have one more iteration, then there is more chances to have an update.