fix(test): properly verify deferred header flushing for non-WebSocket responses#272
Merged
fzipi merged 4 commits intofix/websocketsfrom Mar 20, 2026
Merged
fix(test): properly verify deferred header flushing for non-WebSocket responses#272fzipi merged 4 commits intofix/websocketsfrom
fzipi merged 4 commits intofix/websocketsfrom
Conversation
5 tasks
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on WebSocket support when WAF is active
fix(test): properly verify deferred header flushing for non-WebSocket responses
Mar 12, 2026
fzipi
approved these changes
Mar 13, 2026
Member
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
Contributor
Author
Fixed in c926a7e. The two |
fzipi
approved these changes
Mar 20, 2026
fzipi
added a commit
that referenced
this pull request
Apr 12, 2026
… responses (#272) * Initial plan * fix(test): use writeHeaderTracker to properly verify deferred flushing Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com> * fix(lint): check error return values for ProcessRequestBody and Write Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
fzipi
added a commit
that referenced
this pull request
Apr 14, 2026
… responses (#272) * Initial plan * fix(test): use writeHeaderTracker to properly verify deferred flushing Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com> * fix(lint): check error return values for ProcessRequestBody and Write Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestNonWebSocketResponseDoesNotFlushImmediatelywas assertingrec.Code == 200, buthttptest.ResponseRecorder.Codedefaults to200regardless of whetherWriteHeaderwas ever called — making the assertion vacuously true.Changes
writeHeaderTrackerhelper: wrapshttptest.ResponseRecorderand sets awriteHeaderCalledbool whenWriteHeaderis actually invoked on the underlying writerrequire.Equal(t, http.StatusOK, rec.Code)withrequire.False(t, rec.writeHeaderCalled)— directly verifying the interceptor defers the header flush📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.