fix: ignore no notification warning if webhooks are enabled #8448#8682
Closed
murataslan1 wants to merge 1 commit intocoollabsio:nextfrom
Closed
fix: ignore no notification warning if webhooks are enabled #8448#8682murataslan1 wants to merge 1 commit intocoollabsio:nextfrom
murataslan1 wants to merge 1 commit intocoollabsio:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8448
When a user relied solely on Webhook notifications, the dashboard would incorrectly display a red warning popup stating:
No notifications enabled. It is highly recommended to enable at least one notification channel....This is because the
isAnyNotificationEnabled()method inapp/Models/Team.phpchecked all other notification channels (email, discord, slack, telegram, pushover) to determine if the warning should be suppressed, but it completely omitted checking for webhook channels. This PR adds the missing webhook check.