This repository was archived by the owner on Dec 17, 2025. It is now read-only.
docs: update Dockerfile to use Go modules and go install#2002
Open
So4resAlex wants to merge 1 commit into
Open
docs: update Dockerfile to use Go modules and go install#2002So4resAlex wants to merge 1 commit into
So4resAlex wants to merge 1 commit into
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
aashiq-q
approved these changes
Oct 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR contributes
This PR updates the documentation to include an updated Dockerfile that simplifies the build process for amazon-ecr-credential-helper. The following changes have been made:
Enabled Go modules (GO111MODULE=on)
Simplified installation using go install with the latest version of the repository
Set a default command to run docker-credential-ecr-login
Added comments for better readability and maintainability