chroot: error out on --network != host when $BUILDAH_ISOLATION#6697
Open
nalind wants to merge 1 commit intocontainers:mainfrom
Open
chroot: error out on --network != host when $BUILDAH_ISOLATION#6697nalind wants to merge 1 commit intocontainers:mainfrom
nalind wants to merge 1 commit intocontainers:mainfrom
Conversation
dosubot
bot
added
the
size:XS
nalind
force-pushed
the
isolation-env
branch
from
be49cc8 to
73c0320
Compare
Error out if someone tries to mix the --network CLI flag, with a value other than "host", with chroot isolation configured by setting $BUILDAH_ISOLATION to "chroot", as we have been doing for cases where it's done using the "--isolation" option, instead of just ignoring it as we did previously. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
isolation-env
branch
from
73c0320 to
f045c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Error out if someone tries to mix the --network CLI flag, with a value other than "host", with chroot isolation configured by setting $BUILDAH_ISOLATION to "chroot", as we have been doing for cases where it's done using the "--isolation" option, instead of just ignoring it as we did previously.
How to verify it
Updated integration test!
Which issue(s) this PR fixes:
Fixes #6696
Special notes for your reviewer:
Does this PR introduce a user-facing change?