Conversation
Frequently when run against non-main branches, commits have been backported with a `[<branch name>]` prefix in their title(s). This can easily cause them to run over the title-length checker action. Fix this by restricting it to only running on pull requests targeted at the `main` branch. Signed-off-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Chris Evich <cevich@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Ref: Workflow log with the too-long "DO NOT MERGE: ..." commit 26a4c1c. |
cevich
force-pushed
the
fix_commit_validation_workflow
branch
from
26a4c1c to
614666c
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
Ref: Workflow log without the too-long "DO NOT MERGE: ..." |
|
@cevich I like the idea, but the tests don't as of yet. |
|
Ugh, must be flakes. I didn't touch any code other than the workflow! 😞 I'll rebase and re-run shortly. |
dosubot
bot
added
the
size:S
|
There we go, the Cirrus tests are all green. I dunno about the testing farm stuff and/or if that's required or not. |
|
A friendly reminder that this PR had no activity for 30 days. |
|
This looks like it'll accomplish the goal, but once we limit the validation check to |
I'm not sure what the actual limit is, but by my understanding, there's also no way to increase that limit. The solution would have to be "use a different tool". For now, IMHO it's probably fine to have this but keep is as "optional" in case it fails again. |
3 participants
What type of PR is this?
/kind other
What this PR does / why we need it:
Fix commit title-length checking workflow bug. Also, skip running this check for PR's NOT targeting the
mainbranch. These are typically renovate and/or release-branches that often have extended commit titles w/ additional context details.How to verify it
The workflow will fail on this PR when the very long 'DO NOT MERGE:...' commit is included. But the workflow will pass when that commit is removed.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?