[converter] Add MergeManifest option to tell converter when manifests are merged#674
Merged
imeoer merged 1 commit intocontainerd:mainfrom Sep 9, 2025
Merged
Conversation
… are merged When both the OCI and nydus manifests are merged with `nydusify --merge-platform` for instance, containerd will try to pull an unpack both images even if it doesn't have a nydus-snapshotter. Which results in the nydus image failing to be unpacked and a global image pull failure. One way to fix this issue is to use a config mediaType that containerd doesn't understand in the nydus image. This way it won't attempt to unpack it while the nydus snapshotter can still discover the image and pull it. We use `application/vnd.nydus.image.config.v1+json` as the new config value only used if MergeManifest is set in the MergeOption.
10 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
- Coverage 20.62% 20.62% -0.01%
==========================================
Files 122 122
Lines 13706 13709 +3
==========================================
Hits 2827 2827
- Misses 10561 10564 +3
Partials 318 318
🚀 New features to boost your workflow:
|
Collaborator
|
Thanks! |
Fricounet
added a commit
to Fricounet/acceleration-service
that referenced
this pull request
Sep 9, 2025
Use MergeOption.MergeManifest introduced in nydus-snapshotter v0.15.3 (containerd/nydus-snapshotter#674)
Fricounet
added a commit
to Fricounet/acceleration-service
that referenced
this pull request
Sep 9, 2025
Use MergeOption.MergeManifest introduced in nydus-snapshotter v0.15.3 (containerd/nydus-snapshotter#674) Signed-off-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
imeoer
pushed a commit
to goharbor/acceleration-service
that referenced
this pull request
Sep 9, 2025
Use MergeOption.MergeManifest introduced in nydus-snapshotter v0.15.3 (containerd/nydus-snapshotter#674) Signed-off-by: Baptiste Girard-Carrabin <baptiste.girardcarrabin@datadoghq.com>
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Please briefly describe the changes your pull request makes.
When both the OCI and nydus manifests are merged with
nydusify --merge-platformfor instance, containerd will try to pull an unpack both images even if it doesn't have a nydus-snapshotter. Which results in the nydus image failing to be unpacked and a global image pull failure. One way to fix this issue is to use a config mediaType that containerd doesn't understand in the nydus image. This way it won't attempt to unpack it while the nydus snapshotter can still discover the image and pull it.We use
application/vnd.nydus.image.config.v1+jsonas the new config value only used if MergeManifest is set in the MergeOption.Related Issues
Please link to the relevant issue. For example:
Fix #123orRelated #456.See #669 (comment) for context
Change Details
Please describe your changes in detail:
Test Results
If you have any relevant screenshots or videos that can help illustrate your changes, please add them here.
When propagating the change up to nydusify (see all the changes done in nydusify directly), this will result in an artifact as follow (note the config mediaType):
Change Type
Please select the type of change your pull request relates to:
Self-Checklist
Before submitting a pull request, please ensure you have completed the following: