Skip to content

Test #10709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Parag Badani (pbadani) wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test #10709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ksqldb-functional-tests/src/test/java/io/confluent/ksql/test/rest/RestTestExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,12 @@ void buildAndExecuteQuery(final RestTestCase testCase) {
IntegrationTestUtil.waitForPersistentQueriesToProcessInputs(kafkaCluster, engine);
}

final List<RqttResponse> queryResults = sendQueryStatements(testCase, statements.queries,
try {
Thread.sleep(100);
Copy link

Copilot AI Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The hard-coded delay of 100ms might be arbitrary; consider extracting this value as a named constant or adding a comment to explain its significance, ensuring future maintainability.

Suggested change
Thread.sleep(100);
Thread.sleep(QUERY_PROCESSING_DELAY_MS);

Copilot uses AI. Check for mistakes.
} catch (InterruptedException e) {
Copy link

Copilot AI Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider restoring the thread's interrupted status inside the catch block (e.g., calling Thread.currentThread().interrupt()) before throwing the RuntimeException to ensure proper interruption propagation.

Suggested change
} catch (InterruptedException e) {
} catch (InterruptedException e) {
Thread.currentThread().interrupt();

Copilot uses AI. Check for mistakes.
throw new RuntimeException(e);
}
final List<RqttResponse> queryResults = sendQueryStatements(testCase, statements.queries,
postInputConditionRunnable);

if (!queryResults.isEmpty()) {
Expand Down