add jmx monitoring using grafana prometheus step by step#225
Open
TS (tsuz) wants to merge 2 commits intoconfluentinc:masterfrom
Open
add jmx monitoring using grafana prometheus step by step#225TS (tsuz) wants to merge 2 commits intoconfluentinc:masterfrom
TS (tsuz) wants to merge 2 commits intoconfluentinc:masterfrom
Conversation
Alexandra Rodoni (arodoni)
requested a review
from Akhilesh Manjunath (akhileshm1)
Comment on lines
+64
to
+66
| - "zookeeper-0.zookeeper.confluent.svc.cluster.local:7778" | ||
| - "zookeeper-1.zookeeper.confluent.svc.cluster.local:7778" | ||
| - "zookeeper-2.zookeeper.confluent.svc.cluster.local:7778" |
There was a problem hiding this comment.
Could you use a ServiceMonitor from Prometheus Operator / kube-prometheus to simplify this?
Contributor
There was a problem hiding this comment.
TS (@tsuz) Could you take a look at the request above?
Contributor
Author
There was a problem hiding this comment.
Jordan Moore (@OneCricketeer) Alexandra Rodoni (@arodoni)
Apologizes. I've tried but I have not had success. Let me take a look at this again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #224