Improve formatting, readability and add newlines#551
Open
aaronj0 wants to merge 1 commit intocompiler-research:mainfrom
Open
Improve formatting, readability and add newlines#551aaronj0 wants to merge 1 commit intocompiler-research:mainfrom
aaronj0 wants to merge 1 commit intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 76.27% 76.27%
=======================================
Files 9 9
Lines 3650 3650
=======================================
Hits 2784 2784
Misses 866 866
🚀 New features to boost your workflow:
|
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
We generally don’t add white space change PRs. Is there a particular reason to add this one? |
Collaborator
Author
While a few changes in the CMake are whitespaces (mostly deletions that won't show up on a blame), a lot of files are not newline terminated, which I think should be addressed. They make reading diffs harder, and is not good practice in terms of POSIX standards. |
8a3748c to
850bdd0
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
approved these changes
Apr 23, 2025
Contributor
vgvassilev
left a comment
There was a problem hiding this comment.
LGTM, please remove the remaining new line changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.