Add interface file#8
Conversation
|
Can you compare the runtime before and after this change. I want to make sure we do not do the slow json fetch parameter operation in a hot function somewhere... |
Sure, I am pretty sure the run time is going to be very similar. I only read the json in the beginning and then the parameters are acceded from a struct that extends ParamGroup as BioDynaMo recomends |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
left a comment
There was a problem hiding this comment.
LGTM! Thank you @salva24!
No description provided.