ShapeOp binding#2
Merged
tomvanmele merged 1 commit intocompas-dev:mainfrom May 6, 2025
petrasvestartas:shapeop_binding
Merged
Conversation
tomvanmele
approved these changes
May 6, 2025
Member
tomvanmele
left a comment
There was a problem hiding this comment.
as discussed, it is great to have a one-to-one python binding of the C++ code, but i think we need an easier to use API as well.
let's already merge this one and work on the API in a next round. otherwise things will get to complicated and difficult to review...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most important files, related to API are these ones:
The rest is documentation, examples, test, github actions and building.
Features:
Repositories that helped to reverse engineer this library:
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.