chore: alpha 4 release

[undead2146]

This PR creates the alpha 4 release merge commit

Greptile Summary

This PR merges multiple feature branches for the alpha 4 release, consolidating 19 commits with significant enhancements across game installation management, content provider infrastructure, UI improvements, and update mechanisms.

Key Changes

• Manual Installation Storage: Added persistent storage for manually registered game installations with ManualInstallationStorage service and comprehensive diagnostic logging throughout GameInstallationService
• Provider Configuration System: Introduced data-driven provider definitions via external JSON files (ProviderDefinitionLoader, ContentPipelineFactory) enabling dynamic content source configuration
• GeneralsOnline Integration: New GeneralsOnlineProfileReconciler service for syncing profile metadata and automatic update detection
• Setup Wizard: Implemented guided game profile creation with SetupWizardService and supporting UI
• Enhanced Update Manager: Extended VelopackUpdateManager with artifact builds support, PR/branch subscriptions, and development channel updates
• Settings Enhancements: Added data directory access, complete user data deletion, and application uninstall functionality
• Local Content Feature: New AddLocalContentViewModel with file tree browsing for importing local mods/maps
• Game Settings Refactor: Centralized mapping logic in GameSettingsMapper with improved persistence handling
• Version Utilities: New VersionComparer helper for semantic versioning across different format conventions

Testing & Documentation

• Comprehensive test coverage added for new services (639 lines in test files)
• Architecture documentation updated with provider configuration guides
• Build process streamlined with new build-release.ps1 script

Confidence Score: 4/5

• This PR is largely safe to merge with one potential deadlock issue that should be reviewed
• Score reflects high-quality implementation with comprehensive error handling, extensive test coverage, and well-structured architecture. The one logic issue involves a potential deadlock in GameInstallationService.InvalidateCache() where GetAwaiter().GetResult() is called while holding a synchronous lock. Otherwise, the changes demonstrate solid engineering practices with proper async/await patterns, resource disposal, caching strategies, and diagnostic logging throughout.
• Pay close attention to GameInstallationService.cs:227 where the synchronous lock with async call could cause threading issues

Important Files Changed

Filename	Overview
GenHub/GenHub/Features/GameInstallations/GameInstallationService.cs	Added manual installation storage with diagnostic logging; potential deadlock risk in InvalidateCache using GetAwaiter().GetResult()
GenHub/GenHub/Features/GameInstallations/ManualInstallationStorage.cs	New persistence layer for manual installations with proper async locking and error handling
GenHub/GenHub/Features/AppUpdate/Services/VelopackUpdateManager.cs	Enhanced update checking with caching, PR/branch subscriptions, and artifact installation support
GenHub/GenHub.Core/Services/Providers/ProviderDefinitionLoader.cs	New provider configuration loader supporting both bundled and user-defined JSON provider definitions
GenHub/GenHub/Features/Settings/ViewModels/SettingsViewModel.cs	Added data directory access, delete all user data functionality, and uninstall support
GenHub/GenHub/Features/Content/Services/ContentPipelineFactory.cs	New factory for dynamically creating content pipelines from provider definitions

Sequence Diagram

sequenceDiagram
    participant User
    participant UI as UI/ViewModel
    participant InstallService as GameInstallationService
    participant ManualStorage as ManualInstallationStorage
    participant Detector as InstallationDetector
    participant ContentFactory as ContentPipelineFactory
    participant ProviderLoader as ProviderDefinitionLoader
    participant UpdateManager as VelopackUpdateManager

    Note over User,UpdateManager: Manual Installation Flow (New Feature)
    User->>UI: Select installation folder
    UI->>InstallService: RegisterManualInstallationAsync()
    InstallService->>ManualStorage: SaveManualInstallationAsync()
    ManualStorage-->>InstallService: Success
    InstallService->>Detector: DetectGameClients()
    Detector-->>InstallService: GameClients
    InstallService-->>UI: Installation registered

    Note over User,UpdateManager: Provider Configuration Loading (New Architecture)
    UI->>ProviderLoader: LoadProvidersAsync()
    ProviderLoader->>ProviderLoader: Load bundled JSON providers
    ProviderLoader->>ProviderLoader: Load user JSON providers (override)
    ProviderLoader-->>UI: Provider definitions
    UI->>ContentFactory: CreatePipeline(providerDef)
    ContentFactory->>ContentFactory: Instantiate discoverer/resolver/deliverer
    ContentFactory-->>UI: Content pipeline ready

    Note over User,UpdateManager: App Update with Artifact Support (Enhanced)
    User->>UI: Check for updates
    UI->>UpdateManager: CheckForUpdatesAsync()
    UpdateManager->>UpdateManager: Check GitHub releases (cached)
    UpdateManager-->>UI: Update available
    User->>UI: Check development builds
    UI->>UpdateManager: CheckForArtifactUpdatesAsync()
    UpdateManager->>UpdateManager: Query GitHub Actions artifacts
    UpdateManager-->>UI: Artifact available
    User->>UI: Install artifact
    UI->>UpdateManager: InstallArtifactAsync()
    UpdateManager->>UpdateManager: Download artifact, extract nupkg
    UpdateManager->>UpdateManager: Start local HTTP server
    UpdateManager->>UpdateManager: Apply update via Velopack
    UpdateManager-->>UI: Restart application

Loading

[undead2146]

@greptile

[greptile-apps]

_{202 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

logic: Using GetAwaiter().GetResult() inside a lock can cause deadlocks. The _cacheLock is held synchronously while waiting for an async operation to complete.

Suggested change

	manualInstallationStorage.ClearAllAsync(default).GetAwaiter().GetResult();
	await manualInstallationStorage.ClearAllAsync(cancellationToken).ConfigureAwait(false);

Prompt To Fix With AI

This is a comment left during a code review.
Path: GenHub/GenHub/Features/GameInstallations/GameInstallationService.cs
Line: 227:227

Comment:
**logic:** Using `GetAwaiter().GetResult()` inside a lock can cause deadlocks. The `_cacheLock` is held synchronously while waiting for an async operation to complete.

```suggestion
                    await manualInstallationStorage.ClearAllAsync(cancellationToken).ConfigureAwait(false);
```

How can I resolve this? If you propose a fix, please make it concise.

[greptile-apps]

Too many files changed for review. (785 files found, 500 file limit)

[kilo-code-bot]

WARNING: Manual workflow dispatch will never run

For workflow_dispatch events, github.event.workflow_run is undefined, so this if condition evaluates to false and skips the job entirely. If you intend manual runs to work, the condition should allow workflow_dispatch (e.g., check github.event_name).

[kilo-code-bot]

WARNING: BuildChannel output is never set in this job

steps.buildinfo.outputs.CHANNEL is referenced here, but the build-info step only echoes SHORT_HASH, PR_NUMBER, and VERSION. This leaves BuildChannel empty in CI builds, which can cause incorrect channel tagging or defaults. Consider exporting CHANNEL in the build-info step.

[kilo-code-bot]

WARNING: Build-time UploadThing token embedded in the client

Injecting the UploadThing token into a shipped binary means the secret is recoverable from artifacts and end-user installs, which allows unauthorized uploads or abuse. Consider moving uploads behind a server-side broker or issuing short-lived, scoped tokens instead of embedding a long-lived secret in the client.