Skip to content

refactor: migrate to control flow syntax#2132

Open
lekhmanrus wants to merge 1 commit intocommudle:release/testfrom
lekhmanrus:refactor/no-ref/migrate-to-control-flow-syntax
Open

refactor: migrate to control flow syntax#2132
lekhmanrus wants to merge 1 commit intocommudle:release/testfrom
lekhmanrus:refactor/no-ref/migrate-to-control-flow-syntax

Conversation

@lekhmanrus
Copy link

PR Template

Type

  • ( ) Fix
  • (x) Refactor
  • ( ) Style
  • ( ) Docs
  • ( ) Feat
  • ( ) Hotfix
  • ( ) Merge
  • ( ) Revamp
  • ( ) Chore

Description

  • Migrate to Angular control flow syntax
  • Upgrade prettier to support control flow syntax
  • Format all

Screenshots

Testing

Bundle Size

@arpansac
Copy link
Contributor

Thank you so much @lekhmanrus for raising this PR, quick question if you were able to test it locally?

@lekhmanrus
Copy link
Author

Hey @arpansac,
Yes, I’ve tested it locally by running npx nx run commudle-admin:serve and everything seems to be working fine.

@arpansac
Copy link
Contributor

Thanks @lekhmanrus, one more check (lengthy one) is to go through the files and see in case it has created the right logic as compared to ngIf/for/switch because in some cases it was added over an extra parent div/html tag which can now be removed, saving some lines of code.

@lekhmanrus
Copy link
Author

@arpansac, I get your point about removing extra wrapper elements, but those extra tags might be intentional - for styling, layout or structural directives that rely on proper DOM hierarchy.
Removing them might simplify the markup slightly, but it could also introduce visual or behavioral regressions that are hard to catch without thorough UI testing. I’d suggest keeping them for now unless we can confirm in each case that they’re not used for CSS/layout or component structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants