Allow shortcut reference link before unmatched label#483
Open
mgeier wants to merge 1 commit intocommonmark:masterfrom
Open
Allow shortcut reference link before unmatched label#483mgeier wants to merge 1 commit intocommonmark:masterfrom
mgeier wants to merge 1 commit intocommonmark:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is of course an edge case. I still think the spec should be changed to be more consistent.
This concerns example 540 from the spec 0.27:
Everywhere else, reference links are only recognized if they are matching. Unmatched reference links don't have any significance to the parser.
Therefore, in this case, the unmatched reference link
[foo][bar]should also not have any significance, and the parser should continue to happily match[foo]as shortcut reference link.