Skip to content

build_release: check file sizes in CI#38066

Open
sshane wants to merge 3 commits into
masterfrom
test-all-file-sizes
Open

build_release: check file sizes in CI#38066
sshane wants to merge 3 commits into
masterfrom
test-all-file-sizes

Conversation

@sshane
Copy link
Copy Markdown
Collaborator

@sshane sshane commented May 19, 2026

build_release.sh, which pushes and throws the GitHub error, is only run in Jenkins after we push the blank __nightly branch. build_stripped.sh is run in GH CI, but doesn't build. To surface the issue after build time, before Jenkins we need this additional step in the build release test

@github-actions
Copy link
Copy Markdown
Contributor

Process replay diff report

Replays driving segments through this PR and compares the behavior to master.
Please review any changes carefully to ensure they are expected.

✅ 0 changed, 66 passed, 0 errors

@sshane
Copy link
Copy Markdown
Collaborator Author

sshane commented May 19, 2026

looks like pickles on PC are smaller than device

@adeebshihadeh
Copy link
Copy Markdown
Contributor

Or we can add to scons itself?

@sshane
Copy link
Copy Markdown
Collaborator Author

sshane commented May 19, 2026

@Armandpl why is my comma four building a smaller file size than the CI device?

comma@comma-46755d00:/data/openpilot/selfdrive/modeld/models$ ls -lah | grep driving_tinygrad
-rw-r--r-- 1 comma comma  72M May 19 05:06 driving_tinygrad.pkl
-rw-r--r-- 1 comma comma  45M May 19 05:06 driving_tinygrad.pkl.chunk01of04
-rw-r--r-- 1 comma comma  27M May 19 05:06 driving_tinygrad.pkl.chunk02of04
-rw-r--r-- 1 comma comma    0 May 19 05:06 driving_tinygrad.pkl.chunk03of04
-rw-r--r-- 1 comma comma    0 May 19 05:06 driving_tinygrad.pkl.chunk04of04
-rw-r--r-- 1 comma comma    1 May 19 05:06 driving_tinygrad.pkl.chunkmanifest

@Armandpl
Copy link
Copy Markdown
Contributor

you're building without CI=1 so it's building only one camera
#38008

@adeebshihadeh
Copy link
Copy Markdown
Contributor

Why is CI=1 different? That almost certainly shouldn't be there.

@Armandpl
Copy link
Copy Markdown
Contributor

Armandpl commented May 20, 2026

it's different so we test building for both camera resolutions
on device it builds only for the relevant resolution

@adeebshihadeh
Copy link
Copy Markdown
Contributor

Why can't we build for both on device?

@Armandpl
Copy link
Copy Markdown
Contributor

we can, but it is slower, especially if building both big and small models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants