Fix #377: Don't apply perms to folders when createFolders=true#420
Open
HuiNeng6 wants to merge 3 commits intocom-lihaoyi:mainfrom
Open
Fix #377: Don't apply perms to folders when createFolders=true#420HuiNeng6 wants to merge 3 commits intocom-lihaoyi:mainfrom
HuiNeng6 wants to merge 3 commits intocom-lihaoyi:mainfrom
Conversation
… with SubProcess.scala Fixes issue com-lihaoyi#406
The broken pipe handler thread was preventing the program from exiting because it was not marked as a daemon thread. This fix marks the thread as daemon so the program can exit normally after the pipeline completes. Based on the suggested fix in issue com-lihaoyi#417 by JaredNeil.
…true When using createFolders=true with a custom perms setting, the perms were also applied to the created directories. This caused the directories to lack executable permission, making them inaccessible. This fix removes the perms parameter from makeDir.all calls, so directories are created with default permissions (which include executable permission).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #377
Problem
When using createFolders=true with a custom perms setting, the perms were also applied to created directories, causing them to lack executable permission.
Solution
Remove the perms parameter from makeDir.all calls when createFolders=true. Directories are now created with default permissions.
Changes
Modified 4 locations in ReadWriteOps.scala