Add Task.Command#makeExclusive#6959
Open
alexarchambault wants to merge 3 commits intocom-lihaoyi:mainfrom
Open
Add Task.Command#makeExclusive#6959alexarchambault wants to merge 3 commits intocom-lihaoyi:mainfrom
alexarchambault wants to merge 3 commits intocom-lihaoyi:mainfrom
Conversation
Member
Is the resulting binary even calling the I think I'm open to the idea of this PR, but have issue with the name, which claims to be a harmless property changer, while what we get is a potentially new command with an copied implementation. I'd prefer a name that make this more clear, but I currently don't have an idea. Maybe there are some good naming patterns in the copy-on-write domain? |
Collaborator
Author
|
I initially named it |
Collaborator
Author
|
Just changed it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New attempt at #6928
This adds a
makeExclusivehelper onTask.Command, that can be used to make a copy of the command withexclusiveset to true.This can be helpful if users want to make existing Mill commands exclusive, like
This can be useful in some contexts, like if the tests do fancy terminal stuff and cannot run in parallel because of that, or when publishing locally many modules at a time while passing
--transitive=true(if several command runs try to publish a given transitive dependency at the same time, they sometimes clash, with one writing files that the other doesn't expect to exist already).