Allow customising linker OutputDirectory#6933
Open
Quafadas wants to merge 10 commits intocom-lihaoyi:mainfrom
Open
Allow customising linker OutputDirectory#6933Quafadas wants to merge 10 commits intocom-lihaoyi:mainfrom
Quafadas wants to merge 10 commits intocom-lihaoyi:mainfrom
Conversation
Contributor
Author
|
To me, the failing test does not look related to this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to #6932 .
I think this is the minimally invasive change which enables this.
Tests use a copy (taken from scala js repo) of the
MemOutputDirectory.scalato check that the linking functions write into aCustomOutputwriter as expected.Whether it's a good idea or not is up for discussion; it seems to be philosophically compatible with
ScalaJSConfigModule. My motivation is to experiment with post-processing the linker outputs in a plugin. Link -> re-write -> Hash -> refresh loop without disk IO overhead.Ideally; I think it would have been possible to do that experiment without changing mill. That seems to me both an argument for and against this PR.