Skip to content

Fix some trapped output#6896

Draft
alexarchambault wants to merge 1 commit intocom-lihaoyi:mainfrom
alexarchambault:trapped-output
Draft

Fix some trapped output#6896
alexarchambault wants to merge 1 commit intocom-lihaoyi:mainfrom
alexarchambault:trapped-output

Conversation

@alexarchambault
Copy link
Copy Markdown
Collaborator

Consider this change with caution. I'm opening this more as an issue than as a PR (although if you think the change is fine, let's merge it).

When printing things to stderr right after this line, without this change, the printed stuff gets trapped. Diving into this with Claude AI, I ended up finding that this change fixes that problem. It also doesn't break the CI.

I don't understand much about all the proxy stream / prompt logger and all logic, so I'm not sure what other implications this change could have.

@alexarchambault
Copy link
Copy Markdown
Collaborator Author

This has been a big problem for me when debugging things in Mill, as things I print with pprint end up trapped.

@alexarchambault alexarchambault requested a review from lihaoyi March 3, 2026 19:12
@lihaoyi
Copy link
Copy Markdown
Member

lihaoyi commented Mar 4, 2026

@alexarchambault could you dig into the code to see where this variable gets used later on? Should try to figure out what it's doing and propose a mechanism for the bug and fix rather than just changing it blindly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants