Draft
Conversation
Collaborator
Author
|
This has been a big problem for me when debugging things in Mill, as things I print with pprint end up trapped. |
Member
|
@alexarchambault could you dig into the code to see where this variable gets used later on? Should try to figure out what it's doing and propose a mechanism for the bug and fix rather than just changing it blindly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider this change with caution. I'm opening this more as an issue than as a PR (although if you think the change is fine, let's merge it).
When printing things to stderr right after this line, without this change, the printed stuff gets trapped. Diving into this with Claude AI, I ended up finding that this change fixes that problem. It also doesn't break the CI.
I don't understand much about all the proxy stream / prompt logger and all logic, so I'm not sure what other implications this change could have.