Open
Conversation
Contributor
Author
|
The CI failure doesn't look related to this PR? Please confirm. |
Member
|
@vaslabs can you help review this |
vaslabs
reviewed
Feb 19, 2026
| * KAPT compiler plugin dependency. | ||
| */ | ||
| def kaptPluginMvnDeps: T[Seq[Dep]] = Task { | ||
| Seq(mvn"org.jetbrains.kotlin:kotlin-annotation-processing-embeddable:${kaptVersion()}") |
Contributor
There was a problem hiding this comment.
is there a non embeddable dependency to choose if the user overrides?
override def kotlinUseEmbeddableCompiler: Task[Boolean] = Task { true }
vaslabs
reviewed
Feb 19, 2026
| allKotlincOptions(), | ||
| Seq( | ||
| "-P", | ||
| s"plugin:org.jetbrains.kotlin.kapt3:aptMode=$aptMode", |
Contributor
There was a problem hiding this comment.
could these be in apClasspathOpts ?
Contributor
|
lgtm on first glance, put comments on some minor nits @souvlakias if you can also have a look at this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kapt is a Kotlin compiler plugin and/or Kotlin plugin for "old" Java and pre-ksp use cases. It's slower and in "maintenance" mode but still available.
It's needed to port existing Java code (still relying on annotation processors) and many things still don't have Ksp support.
Not to mention Ksp 2 still has some hard bugs that aren't fixed yet (so it's not strictly worse).