feat(install): allow install from local package #265
+88
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
changed the title
lidavidm
approved these changes
Jan 22, 2026
| } | ||
|
|
||
| func (m progressiveInstallModel) Init() tea.Cmd { | ||
| if strings.HasSuffix(m.Driver, ".tar.gz") { |
Member
There was a problem hiding this comment.
Should we also allow .tgz? Though it looks like CI only uses .tar.gz
lidavidm
reviewed
Jan 22, 2026
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
It installed the package to /home/lidavidm/.config/adbc/drivers/drivername_linux_amd64_v0.1.0.toml which isn't what I'd expect, is it possible to get the 'right' name from the package itself? I guess the info isn't there...
Member
Author
|
Yea, I don't think the info is there, the only option I have is to use the base name of the file. Otherwise we'd need to enforce the name of the package for us to parse it out? I guess I could just check if the filename matches that pattern? |
Member
|
I think it should at least reject the package or maybe ask you to specify a name since the name as-is isn't usable by the driver manager. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #262