Skip to content

Fix for modals not reacting to the Esc key & for file input field not gaining focus#1768

Merged
ArtOfCode- merged 3 commits intodevelopfrom
0valt/1611/tabbing
Aug 10, 2025
Merged

Fix for modals not reacting to the Esc key & for file input field not gaining focus#1768
ArtOfCode- merged 3 commits intodevelopfrom
0valt/1611/tabbing

Conversation

@Oaphi
Copy link
Copy Markdown
Member

@Oaphi Oaphi commented Aug 8, 2025

closes #1611

2 fixes:

  • modals now react to the Esc key being presses as expected (they should close);
  • file input field is now focused when the image upload modal is opened;
ssr-2025-08-09_00.11.13.mp4

@Oaphi Oaphi added this to the v0.12.3 milestone Aug 8, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.78%. Comparing base (2ae9944) to head (cdde07b).
⚠️ Report is 22 commits behind head on develop.

Additional details and impacted files
Components Coverage Δ
controllers 69.86% <ø> (ø)
helpers 81.82% <ø> (ø)
jobs 60.00% <ø> (ø)
models 86.12% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@cellio cellio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a post draft, I tested the image and link buttons. The image file has focus (so you don't need the mouse), and escape closes both modals. If you didn't mean to close a link modal, I see that your previous typing is still there if you choose it again, and only on that post (other posts start fresh) -- all expected behavior.

I'm not sure what other modals are affected. I didn't observe any differences with close or flag operations. I suppose "modal" means "thing that seems to pop over your screen and take control"? I can't think of others of those off hand; happy to test if someone reminds me where.

@ArtOfCode- ArtOfCode- merged commit 10fbb1c into develop Aug 10, 2025
19 of 20 checks passed
@ArtOfCode- ArtOfCode- deleted the 0valt/1611/tabbing branch August 10, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tab context not transferred to image upload dialog

3 participants