🤖 refactor: auto-cleanup

[mux-bot]

Summary

Long-lived auto-cleanup PR maintained by the Auto-Cleanup Agent. Each pass lands at most one extremely low-risk, behavior-preserving cleanup drawn from recently merged main activity, then advances the checkpoint below. The prior long-lived PR (#3559) merged into main; this is its successor.

Auto-cleanup checkpoint: 2af29df

This pass

Considered the one new main commit since the previous checkpoint — #3603 (feat: add built-in loop skill). That change adds the advertised loop built-in skill (src/node/builtinSkills/loop.md), regenerates builtInSkillContent.generated.ts (generated — off-limits), and extends the agent-skills discovery test expectations. The skill-content/generated surface offers no safe hand-edit, so the cleanup was drawn from the production sibling of that area: the skill-discovery service agentSkillsService.ts.

Landed one behavior-preserving cleanup in agentSkillsService.ts: readSkillDescriptorFromDir open-coded the same invalid-skill diagnostic push — options?.invalidSkills?.push({ directoryName, scope, displayPath: skillFilePath, message, hint }) — at six failure sites (missing/unreadable SKILL.md, SKILL.md-is-a-directory, oversized file, read failure, invalid descriptor, parse failure). Those six sites share identical identity fields (directoryName / scope / displayPath) and differ only in message + hint. All six now delegate to a single function-local pushInvalidSkill(message, hint) closure that captures the function-constant identity fields. Behavior-preserving: the pushed object shape and every per-site message/hint are unchanged, and the closure short-circuits on options?.invalidSkills exactly as the inline calls did.

Branch contents (net diff against main)

Cleanups carried by this PR (not yet merged)

• agentSkillsService.ts — dedupe invalid-skill diagnostics. 🤖 feat: add built-in loop skill #3603's new built-in skill lives in the agent-skills discovery area; readSkillDescriptorFromDir open-coded the same options?.invalidSkills?.push({ directoryName, scope, displayPath: skillFilePath, message, hint }) at six failure sites that share identical identity fields and differ only in message/hint. All six now delegate to a single function-local pushInvalidSkill(message, hint) closure. Behavior-preserving (identical pushed shape, messages, hints, and options?.invalidSkills short-circuit).
• workspaceGoalService.ts — dedupe session file path resolution. The three private accessors getFilePath / getHistoryFilePath / getBoardFilePath each open-coded the same assert(...non-empty workspaceId) guard and path.join(getSessionDir(...), <FILE_CONST>). All three now delegate to a single resolveSessionFilePath(workspaceId, fileName) helper. Behavior-preserving (identical guard + join; accessor names and callers unchanged).
• task.ts — dedupe plan-agent explore-only error. The plan-agent restriction error In the plan agent you may only spawn agentId: "explore" tasks. was open-coded twice (the workspace-turn guard and the per-launch agent-id guard). Both now reference a single module-level PLAN_AGENT_EXPLORE_ONLY_ERROR constant. Behavior-preserving (identical string output).
• task_await.ts — dedupe workspace-turn error fallback. 🤖 feat: add workspace turn task handles #3600's new workspace-turn await paths open-coded the fallback error message "Workspace turn failed" three times (<record>.error ?? "Workspace turn failed"). All three now reference a single module-level WORKSPACE_TURN_DEFAULT_ERROR constant. Behavior-preserving (identical string output).
• goalToolUtils.tsx / SetGoalToolCall.tsx — dedupe turn-count pluralization. 🤖 feat: add agent-facing goal setting #3595's new goal toolcards open-coded `${n} turn${n === 1 ? "" : "s"}` in both formatGoalTurns and the set_goal toolcard's formatOptionalTurnCap. Both now call a shared pluralizeTurns(count) helper. Behavior-preserving (identical string output).
• heartbeat.ts — dedupe heartbeat tool success result construction. 🤖 feat: add workspace heartbeat tool #3596's new heartbeat tool open-coded the same { success: true, action, configured, settings, summary } success object three times (get / set / unset), each re-calling summarize({ action, settings }). All three now route through a single buildSuccessResult(action, settings) helper that derives configured from settings. Behavior-preserving: the per-branch configured values (settings != null, false, true) all equal settings != null given the non-null Ok payload type for set.
• taskService.ts — dedupe startup recovery candidate listing. 🤖 fix: prevent workflow task recovery after interrupts #3594's TaskService.initialize open-coded the awaiting_report / running candidate filters twice (initial computation and post-interrupt refresh). Both call sites now reuse a single listStartupRecoveryCandidates(sourceConfig) closure returning { awaitingReportTasks, runningTasks }, matching the existing listQueuedTasks pattern. Behavior-preserving.
• ChatPane.tsx — dedupe send-queued-immediately in-flight guard clear. 🤖 fix: send queued message with empty Enter #3592 introduced sendQueuedImmediatelyInFlightRef to block duplicate send-now attempts; releasing that guard ("clear it only if it still points at this attempt") was open-coded twice — once after a failed interrupt result and once in the catch arm. Both call sites now invoke a single callback-local closure clearInFlightGuardIfCurrent(). Behavior-preserving: the failed-result site's combined !interruptResult.success && ref === id becomes if (!interruptResult.success) clearInFlightGuardIfCurrent() (logically identical); the catch site is a verbatim substitution.
• WorkflowRunner.ts — dedupe parallelAgents child-failure abort handling into a single batch-local closure applyChildFailureToBatch(error), shared by the per-run task closure and the bulk-create path.
• ChatInput/index.tsx — dedupe edit-mode attachment toast string "Attachments cannot be added while editing a message." into a single module-level constant EDIT_MODE_ATTACHMENT_ERROR_MESSAGE, replacing three inline copies across the add-attachment / paste / drop guards.

Prior passes (landed via #3559, merged)

• Replaced an inline terminal-status check in WorkflowService.interruptRunOnAbort with the isTerminalWorkflowRunStatus helper.
• Deduplicated the workspaceId-only metadata JSON Schema repeated by three id-targeted host actions in workspaceHostActions.ts into WORKSPACE_ID_ONLY_INPUT_SCHEMA.
• Extracted a shared BlockedBadge component in WorkflowDefinitionToolCall.tsx.
• Deduplicated the repeated argsSchema.properties must be an object error string in workflowArgs.ts.
• Deduplicated mocked-module specifier strings in useModelsFromSettings.test.ts.
• Removed a redundant toggleWorkflowExpanded wrapper in WorkflowRunToolCall.tsx.
• Deduplicated SAVE_AUTOMATION_ERROR_MESSAGE / REMOVE_AUTOMATION_ERROR_MESSAGE in AutomationModal.tsx.
• Replaced a duplicated "wfr_" literal in WorkflowRunner.ts with isWorkflowRunTaskId().

Validation

• make static-check — ESLint, both tsgo typecheck configs, and Prettier all pass on the rebased tree. The only failing step is fmt-shell-check, which requires shfmt (not installed in this environment); no shell scripts were touched, so CI (which has shfmt) is unaffected.
• bun test src/node/services/agentSkills/agentSkillsService.test.ts — 20 pass, 0 fail (covers skill discovery + the invalid-skill diagnostics path this pass deduped); builtInLoopSkill.test.ts — 1 pass.

---

Generated with mux • Model: anthropic:claude-opus-4-8 • Thinking: xhigh

[mux-bot]

@codex review

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

@codex review

Behavior-preserving dedup: extracted the duplicated child-failure abort handling in WorkflowRunner.parallelAgents into a single batch-local applyChildFailureToBatch closure. No control flow changed; bun test WorkflowRunner.test.ts passes (71/0).

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

@codex review

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

⚠️ Auto-fixup: CI failure appears to be a flaky test, not caused by the cleanup commits — no code pushed.

Failed job: Test / Unit (run 27788620602)

Failing tests: src/browser/hooks/useChatTranscriptFullWidth.test.tsx (4 cases)

• uses the cached preference until backend config resolves
• ignores stale config fetches after a newer subscription refresh
• accepts a newer backend refresh after a backend-driven cache update
• caches backend config for the next mount

Root cause: Each failure is a waitFor(() => expect(getConfigMock).toHaveBeenCalledTimes(1)) that times out at ~1000ms with Received number of calls: 0 — the hook's async config-fetch effect did not fire within the window. This occurred only in the coverage-instrumented full-suite run (bun test --coverage --max-concurrency=1), where instrumentation overhead and accumulated process state slow effect scheduling. Classic timing flake.

Why it's unrelated to this PR: the cleanup only touches ChatPane.tsx, ChatInput/index.tsx, taskService.ts, and WorkflowRunner.ts — none of which touch useChatTranscriptFullWidth or its dependencies (API context, usePersistedState, storage constants). The test file itself is unchanged by this branch (last modified in #3350).

Local verification: the suite passes consistently — 8/8 across 5 consecutive runs on this branch.

Recommendation: re-run the failed CI job. No automated fix is warranted since modifying the unrelated test would exceed the cleanup scope. If this test proves persistently flaky under coverage, consider hardening it separately (e.g., a higher waitFor timeout).

[mux-bot]

⚠️ Auto-fixup could not resolve CI failure: the Test / Unit failure is a pre-existing flaky test, not caused by this cleanup PR. No code was pushed.

Failing tests (src/browser/hooks/useChatTranscriptFullWidth.test.tsx):

• uses the cached preference until backend config resolves
• ignores stale config fetches after a newer subscription refresh
• accepts a newer backend refresh after a backend-driven cache update
• caches backend config for the next mount

Why this is a flake, not a regression:

• All four failures are waitFor(...) timeouts at ~1000–1004 ms (the default 1 s timeout), e.g. expect(getConfigMock).toHaveBeenCalledTimes(1) → received 0. getConfigMock is invoked from a React effect inside the hook; under heavy CI parallelism (this job ran 9256 tests across 655 files) the effect/promise occasionally doesn't settle within 1 s.
• This PR (auto-cleanup) only touches ChatPane.tsx, ChatInput/index.tsx, taskService.ts, and WorkflowRunner.ts. It does not modify useChatTranscriptFullWidth (hook or test) nor any of its imports.
• Ran the test locally 5/5 times after bun install — all green (8 pass, 0 fail each run).

(The emitWorkflowRunActivity is not a function lines in the log are caught/logged noise from router.test.ts, which still passes — not the failure source.)

Recommendation: re-run the Test / Unit job. If it keeps flaking, the test should be hardened (e.g. bump the waitFor timeout or await the effect deterministically) in a separate change — out of scope for auto-fixup.

[mux-bot]

@codex review

This pass adds one behavior-preserving cleanup: heartbeat.ts now routes its get / set / unset success returns through a single buildSuccessResult(action, settings) helper instead of re-assembling the identical { success: true, action, configured, settings, summary } object three times. configured is derived as settings != null, which matches each prior branch (get: already settings != null; unset: null → false; set: non-null Ok payload → true). Checkpoint advanced to c89f5e1.

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

@codex review

This pass extracts a shared pluralizeTurns(count) helper in goalToolUtils.tsx and reuses it in formatGoalTurns and SetGoalToolCall.tsx's formatOptionalTurnCap, deduping the ${n} turn${n === 1 ? "" : "s"} pluralization introduced by #3595. Behavior-preserving (identical string output); checkpoint advanced to 4bac642.

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

@codex review

Periodic auto-cleanup pass: rebased onto latest origin/main and landed one behavior-preserving dedupe in task_await.ts — the "Workspace turn failed" fallback (open-coded 3×) now references a single WORKSPACE_TURN_DEFAULT_ERROR constant. Checkpoint advanced to c263729.

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

⚠️ Auto-fixup could not resolve CI failure: the failing job (Test / Windows, run 27847382625) is a flaky/environmental failure, not a regression from this branch.

Root cause: All 15 Windows failures originate in test scaffolding createTempGitRepo() (tests/ipc/helpers.ts:591), where git init fails with no stderr (Command failed: git init) — including across both retries. This affects tests/ipc/runtime/executeBash.test.ts and tests/ipc/runtime/backgroundBashDirect.test.ts.

Why this is not caused by the cleanup commit:

• The 8 changed files are all unrelated frontend chat/tools + backend task/heartbeat/workflow code; none touch git, runtime, executeBash, backgroundBash, or test helpers.
• Failure is Windows-only — Unit, Integration, E2E (linux/macOS), Storybook, and all Build jobs passed.
• Recent runs of the same Test / Windows job (including on main) pass cleanly; only this run hit the git init flake.

Action: No code pushed (the fix: circuit-breaker is intentionally not triggered). Recommend re-running the Test / Windows job. Manual intervention only needed if the git init flake recurs.

[mux-bot]

⚠️ Auto-fixup could not resolve CI failure: classified as a flaky/environmental Windows failure, not caused by the cleanup commit — no code pushed.

Failed job: Test / Windows (run 27847382625)
Failed suite: tests/ipc/runtime/backgroundBashDirect.test.ts (7 failed)

Root cause (environmental):

• All failures occur in test setup, not in any assertion under test:
  • Failed to create workspace: Command failed with exit code 3221225794
  • Command failed: git init
• 3221225794 = 0xC0000142 (STATUS_DLL_INIT_FAILED) — a well-known transient Windows process-initialization failure that surfaces when spawning processes (here, git) under load on the runner. The log also reports A worker process has failed to exit gracefully and has been force exited, a classic resource-exhaustion symptom.

Why this is not caused by the cleanup commit:

• This PR only touches frontend chat/goal/workflow UI and backend task/heartbeat/workflow service files. None touch workspace creation, git init, PTY, or process spawning.
• The failing suite imports none of the refactored modules.
• The most plausibly-related change (src/node/services/tools/task_await.ts) is a trivial dedupe that extracts an error-string constant (WORKSPACE_TURN_DEFAULT_ERROR) with no behavioral effect.

Recommendation: Re-run the Test / Windows job. If it recurs across unrelated PRs, the backgroundBashDirect workspace-setup path may need hardening/retry on Windows (0xC0000142). Manual intervention / a re-run is needed; no fix was pushed.

---

Generated with mux • Model: anthropic:claude-opus-4-8 • Thinking: xhigh • Cost: $0.00

[mux-bot]

@codex review

Auto-cleanup pass: rebased onto latest origin/main and landed one behavior-preserving dedupe in src/node/services/tools/task.ts — the plan-agent restriction error string was open-coded in two guards and now references a single module-level PLAN_AGENT_EXPLORE_ONLY_ERROR constant. Checkpoint advanced to 9dcfc83 (#3576).

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

@codex review

This pass: deduped the three private session-file path accessors in workspaceGoalService.ts (getFilePath / getHistoryFilePath / getBoardFilePath) — each open-coded the same non-empty workspaceId assert + path.join(getSessionDir(...), <FILE_CONST>) — into a single private resolveSessionFilePath(workspaceId, fileName) helper. Behavior-preserving: accessor names/signatures and all callers unchanged; identical assert message and join at every site. Checkpoint advanced to 5dae4a3.

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

@codex review

Auto-cleanup pass: advanced checkpoint to 2af29dfd14e309bcb4d875eed6080f398dd84fb1 (#3603) and landed one behavior-preserving cleanup in agentSkillsService.ts — readSkillDescriptorFromDir now routes its six invalid-skill diagnostics through a single pushInvalidSkill(message, hint) closure (identical pushed shape/messages/hints).

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.