Skip to content

Conversation

@ethanndickson
Copy link
Member

Summary

  • surface Coder CLI list parsing failures in the runtime UI and Storybook
  • show logged-in Coder username + deployment URL in the runtime header

Background
Coder CLI parsing failures were showing up as empty lists, and the runtime header only displayed the username without the deployment context. We need clearer error visibility and login context in the Coder runtime UX.

Implementation

  • return discriminated {ok,error} results for Coder list endpoints and render their errors
  • plumb whoami data so the UI can show "Logged in as on "
  • extend Storybook mocks and add parse-error stories for templates, presets, and workspaces

Validation

  • make static-check
  • bun test src/node/services/coderService.test.ts src/node/runtime/CoderSSHRuntime.test.ts

Risks
Low; changes are scoped to Coder runtime plumbing, UI messaging, and Storybook mocks.


Generated with mux • Model: openai:gpt-5.2-codex • Thinking: xhigh • Cost: $43.90

@github-actions github-actions bot added the bug label Feb 3, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0ef3b8508

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson
Copy link
Member Author

@codex review

Thanks for the note. We’re going to leave whoami revalidation as-is for now; if the user changes Coder deployments they can restart the app to refresh cached whoami data.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0ef3b8508

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson
Copy link
Member Author

@codex review

Responding to both items:

  • P2 Badge Revalidate whoami before using deployment URL: We’re going to leave whoami revalidation as-is for now. If a user changes Coder deployments, they can restart the app to refresh cached whoami data.
  • P2 Badge Refresh deployment URL after login changes: Same rationale — we’re not addressing cache invalidation in this change set. Restarting the app refreshes whoami and deployment URL.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0ef3b8508

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ethanndickson ethanndickson added this pull request to the merge queue Feb 3, 2026
Merged via the queue into main with commit e11dfb2 Feb 3, 2026
24 checks passed
@ethanndickson ethanndickson deleted the workspace-list-mejv branch February 3, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant