feat: Music Recommender Simulation — complete implementation with evaluation, model card, and tests - #6
Open
jupitersnow1 wants to merge 16 commits into
Open
feat: Music Recommender Simulation — complete implementation with evaluation, model card, and tests#6jupitersnow1 wants to merge 16 commits into
jupitersnow1 wants to merge 16 commits into
Conversation
… pythonic ranking
…nking, and docstrings
…t, and model card
…nted, model card done
serena42
pushed a commit
to serena42/music_recommender_simulation
that referenced
this pull request
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_songs,score_song,recommend_songs, andRecommenderclass insrc/recommender.pymodel_card.md,reflection.md, andREADME.mdTests (Newly Implemented)
test_score_song_genre_match_adds_correct_weight— genre match adds exactly 0.40test_score_song_no_genre_or_mood_match_returns_energy_only— only energy contributes when no genre/mood matchtest_recommend_returns_k_results— k parameter is respectedtest_load_songs_returns_correct_count— CSV loads all 18 songstest_score_song_conflicting_profile— genre + mood match beats pure energy matchtest_recommend_empty_catalog— empty catalog returns empty list without crashingtest_score_song_perfect_match— perfect match scores exactly 1.0test_score_song_energy_boundary— energy at opposite extremes contributes 0.0test_recommend_scores_are_descending— results are always sorted highest to lowestTest plan
python -m src.mainand verify recommendations print for all 6 user profilespytestand confirm 11/11 tests passmodel_card.mdfor completenessFuture Work
Planning to return and expand this project with improvements including mood-as-hard-filter logic, genre grouping fallbacks, and broader catalog coverage.