Enhancement: update reducers for team creation, deletion, and modification.#2
Open
NathanWEdwards wants to merge 1 commit intocodeforbtv:productionfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user creates, deletes, or modifies a team, changes may not immediately appear on the Home and Leaderboard screens.
The teams and profile reducers should handle
SAVE_TEAM_SUCCESSandDELETE_TEAM_SUCCESSto update state.teams.teams.Teams Reducers
CREATE_TEAM_SUCCESSadds a new team to state.team.teamsDELETE_TEAM_SUCCESSremoves state.teams.teams[team.id] and clears selectedTeamSAVE_TEAM_SUCCESSupdates state.teams.teams[team.id]Profile Reducers
CREATE_TEAM_SUCCESSadds a new team entry to state.profile.teamsDELETE_TEAM_SUCCESSremoves the team entry from state.profile.teamsAction Creators
createTeamdispatchesCREATE_TEAM_SUCCESSsaveTeamdispatches the full team objectdeleteTeamdispatchesDELETE_TEAM_SUCCESSwith ateamIdfor removalFirebase Data Layer
createTeamreturns theteamIdforCREATE_TEAM_SUCCESSdispatchesdeleteTeamremoves listeners have a team has been deleted