fix: add function name fallback for Jest timing marker matching#1314
Closed
fix: add function name fallback for Jest timing marker matching#1314
Conversation
When Vitest doesn't provide test context, timing markers may have "unknown" as the test name. This caused marker matching to fail since we were only matching by test name. Added fallback to also match by function name (group 3 in the marker), which is always set correctly even when test name is "unknown". Fixes: - "overall summed benchmark runtime is 0" errors when test names are unknown - Marker matching for Vitest-based projects Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Closing - needs more verification before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When Vitest doesn't provide test context (or when tests are configured in certain ways), timing markers may have "unknown" as the test name. The marker matching logic was only matching by test name (group 2), causing all markers to fail matching.
Example failing marker:
Solution
Added fallback to also match by function name (group 3 in the marker), which is always set correctly:
Test plan
tests/test_verification/test_jest_marker_matching.pyGenerated with Claude Code