fix: use process.stdout.write for timing markers to bypass Vitest interception#1313
Closed
fix: use process.stdout.write for timing markers to bypass Vitest interception#1313
Conversation
…erception Vitest intercepts console.log output and may not pass it to the subprocess stdout. This caused timing markers in capturePerf to not be captured by the parent process. Changed from console.log to process.stdout.write for timing markers in capturePerf to ensure markers are always written directly to stdout. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
|
Closing - needs more verification before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.logtoprocess.stdout.writeProblem
Vitest intercepts
console.logoutput and may not pass it to the subprocess stdout. This caused timing markers incapturePerfto not be captured by the parent process, resulting in "overall summed benchmark runtime is 0" errors.Solution
Changed from:
To:
process.stdout.writewrites directly to the stdout stream, bypassing any console interceptors.Test plan
runtime/__tests__/stdout-write.test.jsprocess.stdout.writeconsole.logGenerated with Claude Code