Skip to content

fix: add start tag output to capturePerf for throughput calculation#1312

Closed
Saga4 wants to merge 1 commit intomainfrom
fix/capturePerf-start-tags
Closed

fix: add start tag output to capturePerf for throughput calculation#1312
Saga4 wants to merge 1 commit intomainfrom
fix/capturePerf-start-tags

Conversation

@Saga4
Copy link
Contributor

@Saga4 Saga4 commented Feb 3, 2026

Summary

  • Adds start tag output (!$######...######$!) to capturePerf before timing measurement
  • Required for throughput calculation and timing marker matching

Problem

capturePerf was only outputting end tags with timing data (!######...######!), but not start tags. This caused:

  1. Throughput calculation to fail (requires counting both start and end tags)
  2. Timing marker matching in parse_test_output.py to fail (expects start tags to exist)

Solution

Added start tag output before timing measurement in capturePerf, matching the behavior of the capture function:

// Print start tag (needed for throughput calculation and timing marker matching)
console.log(`!$######${testStdoutTag}######$!`);

Test plan

  • Added test file runtime/__tests__/capturePerf-start-tags.test.js
  • Test verifies both start and end tags are output
  • Test verifies tag format is correct
  • Manual testing with Vitest-based projects

Generated with Claude Code

capturePerf was only outputting end tags with timing data, but not
start tags. This caused issues with:
1. Throughput calculation (counting completed executions requires both tags)
2. Timing marker matching in parse_test_output.py

Added start tag output (`!$######...######$!`) before timing measurement,
matching the behavior of the `capture` function.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@Saga4
Copy link
Contributor Author

Saga4 commented Feb 3, 2026

Closing - needs more verification before merging

@Saga4 Saga4 closed this Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant