fix: add start tag output to capturePerf for throughput calculation#1312
Closed
fix: add start tag output to capturePerf for throughput calculation#1312
Conversation
capturePerf was only outputting end tags with timing data, but not start tags. This caused issues with: 1. Throughput calculation (counting completed executions requires both tags) 2. Timing marker matching in parse_test_output.py Added start tag output (`!$######...######$!`) before timing measurement, matching the behavior of the `capture` function. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
Author
|
Closing - needs more verification before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!$######...######$!) to capturePerf before timing measurementProblem
capturePerfwas only outputting end tags with timing data (!######...######!), but not start tags. This caused:parse_test_output.pyto fail (expects start tags to exist)Solution
Added start tag output before timing measurement in capturePerf, matching the behavior of the
capturefunction:Test plan
runtime/__tests__/capturePerf-start-tags.test.jsGenerated with Claude Code