Skip to content

⚡️ Speed up function _apply_indentation by 140% in PR #1199 (omni-java) #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 1 commit into from
Closed

⚡️ Speed up function _apply_indentation by 140% in PR #1199 (omni-java) #1306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions codeflash/languages/java/replacement.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from typing import TYPE_CHECKING

from codeflash.discovery.functions_to_optimize import FunctionToOptimize
from codeflash.languages.java.parser import JavaAnalyzer, JavaMethodNode, get_java_analyzer
from codeflash.languages.java.parser import JavaAnalyzer, get_java_analyzer

if TYPE_CHECKING:
pass
Expand Down Expand Up @@ -434,9 +434,11 @@ def _apply_indentation(lines: list[str], base_indent: str) -> str:
# Detect the existing indentation from the first non-empty line
# This includes Javadoc/comment lines to handle them correctly
existing_indent = ""
existing_indent_len = 0
for line in lines:
if line.strip(): # First non-empty line
existing_indent = _get_indentation(line)
existing_indent_len = len(line) - len(line.lstrip())
existing_indent = line[:existing_indent_len]
break

result_lines = []
Expand All @@ -447,11 +449,11 @@ def _apply_indentation(lines: list[str], base_indent: str) -> str:
# Remove existing indentation and apply new base indentation
stripped_line = line.lstrip()
# Calculate relative indentation
line_indent = _get_indentation(line)
line_indent_len = len(line) - len(stripped_line)
# When existing_indent is empty (first line has no indent), the relative
# indent is the full line indent. Otherwise, calculate the difference.
if line_indent.startswith(existing_indent):
relative_indent = line_indent[len(existing_indent) :]
if line_indent_len >= existing_indent_len and line[:existing_indent_len] == existing_indent:
relative_indent = line[existing_indent_len:line_indent_len]
else:
relative_indent = ""
result_lines.append(base_indent + relative_indent + stripped_line)
Expand Down
Loading